GLASGOW | Jan-26-ITP | Prakash Dcosta | Sprint 3 | Alarm Clock#1114
Open
dcostaprakash wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
GLASGOW | Jan-26-ITP | Prakash Dcosta | Sprint 3 | Alarm Clock#1114dcostaprakash wants to merge 3 commits intoCodeYourFuture:mainfrom
dcostaprakash wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
dcostaprakash
added
the
Needs Review
Luro91
added
Review in progress
Luro91
reviewed
Apr 4, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
How could you improve the clarity of the pull request checklist?
Sprint-3/alarmclock/index.html
Outdated
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| <title>Title here</title> | ||
| <title>AlarmClock</title> |
Author
There was a problem hiding this comment.
Thank you. I made the change.
Sprint-3/alarmclock/alarmclock.js
Outdated
| let timerId; | ||
| function setAlarm() { | ||
| const input = document.getElementById("alarmSet").value; | ||
| timeRemaining = Number(input); |
There was a problem hiding this comment.
What happens when the user enters a negative number or a string value?
Author
There was a problem hiding this comment.
Yes. I see it is accepting negative and null inputs. I have made the change. Thank you for pointing it out
| const input = document.getElementById("alarmSet").value; | ||
| timeRemaining = Number(input); | ||
|
|
||
| clearInterval(timerId); |
There was a problem hiding this comment.
Nice clearing of the interval to ensure only one countdown is running
Luro91
added
Reviewed
dcostaprakash
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
my coursework